Skip to content

Add sanitizer support using GCC toolchain features#64

Open
RSingh1511 wants to merge 4 commits intoeclipse-score:mainfrom
RSingh1511:rs/swp-245137
Open

Add sanitizer support using GCC toolchain features#64
RSingh1511 wants to merge 4 commits intoeclipse-score:mainfrom
RSingh1511:rs/swp-245137

Conversation

@RSingh1511
Copy link
Contributor

@RSingh1511 RSingh1511 commented Feb 16, 2026

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • PR title is short, expressive and meaningful
  • Commits are properly organized
  • Relevant issues are linked in the References section
  • Tests are conducted
  • Unit tests are added

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #

@github-actions
Copy link

github-actions bot commented Feb 16, 2026 •
edited
Loading

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 5dc148a5-6f0c-4347-af4a-2abfabe09ab2
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.5.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.7.1, but got bazel_skylib@1.8.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_rust', the root module requires module version rules_rust@0.61.0, but got rules_rust@0.67.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.2.14 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@1.13.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version buildifier_prebuilt@7.3.1, but got buildifier_prebuilt@8.2.0.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0.bcr.1, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 9.905s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@github-actions
Copy link

github-actions bot commented Feb 16, 2026

The created documentation from the pull request is available at: docu-html

@RSingh1511 RSingh1511 marked this pull request as ready for review February 16, 2026 10:03
FScholPer
FScholPer previously approved these changes Feb 16, 2026
View reviewed changes
MaximilianSoerenPollak
MaximilianSoerenPollak reviewed Feb 16, 2026
View reviewed changes
MODULE.bazel
bazel_dep(name = "score_bazel_platforms", version = "0.0.4")
bazel_dep(name = "score_docs_as_code", version = "2.2.0")
bazel_dep(name = "score_tooling", version = "1.1.1")
bazel_dep(name = "score_docs_as_code", version = "2.3.0")
Copy link

@MaximilianSoerenPollak MaximilianSoerenPollak Feb 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need docs-as-code 3.0.1 if you want to use tooling 1.1.2.

Copy link
Contributor Author

@RSingh1511 RSingh1511 Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor Author

@RSingh1511 RSingh1511 Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified that score_docs_as_code@2.3.0 works correctly with score_tooling@1.1.2 and all tests pass. The sanitizer implementation is complete and ready for review.

Using 3.0.1 causes CI failures because score_tooling@1.1.2 declares it as dev_dependency = True, making it invisible to consuming modules.

Copy link

@MaximilianSoerenPollak MaximilianSoerenPollak Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need the new added Documentation API this from tooling 1.1.2?
If not then downgrading to 1.1.0 and upgrading docs-as-code to 3.0.0 would be advisable.
Otherwise you will not be able to use the new features from docs-as-code.
See Features Here

Copy link
Contributor Author

@RSingh1511 RSingh1511 Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Downgraded to score_tooling@1.1.0.

Keeping score_docs_as_code@2.3.0 due to compatibility with score_baselibs (all released versions require 2.3.0). Upgrading to 3.0.0 causes CI failures.

@MaximilianSoerenPollak MaximilianSoerenPollak mentioned this pull request Feb 16, 2026
Open
pawelrutkaq
pawelrutkaq requested changes Feb 17, 2026
View reviewed changes
Copy link
Contributor

@pawelrutkaq pawelrutkaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry we need to postone it until logging in in shape and works with other repos. Then I will review and recheck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pawelrutkaq pawelrutkaq pawelrutkaq requested changes

@FScholPer FScholPer FScholPer approved these changes

@antonkri antonkri Awaiting requested review from antonkri antonkri is a code owner

@arsibo arsibo Awaiting requested review from arsibo arsibo is a code owner

@MaximilianSoerenPollak MaximilianSoerenPollak Awaiting requested review from MaximilianSoerenPollak

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RSingh1511 @MaximilianSoerenPollak @FScholPer @pawelrutkaq